Re: [PATCH v2] lib/ext2fs: add some msg for io error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The e2fsck_handle_write_error is called only unix_write_blk64 and
unix_read_blk64 failed, but there is no failure message in unix_write_byte
and unix_flush.

Thanks,
 - bin.

On 2023/2/24 11:47, Theodore Ts'o wrote:
On Thu, Feb 23, 2023 at 05:01:11PM +0800, zhanchengbin wrote:
Add msgs to show whether there is eio in fsck process, when write and
fsync methods fail.

Signed-off-by: zhanchengbin <zhanchengbin1@xxxxxxxxxx>

The libext2fs is a *library*.  As such, well designed libraries do not
randomly write to stderr.  Consider what might happen if there was a
curses based program that was calling libext2fs --- for example, like
the ext2ed program.  Writing random errors to stderr is just *rude*.   :-)

If what you're worried about errors from e2fsck, it's also not
necessary, since that's what the error handler callback is for.

Cheers,

					- Ted
.




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux