On Fri, Feb 10, 2023 at 03:48:15AM +0800, Kemeng Shi wrote: > e4b->bd_buddy_page is only set if we initialize ext4_buddy successfully. So > e4b->bd_buddy_page is always NULL in error handle branch. Just remove the > dead check. > > Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> > --- > fs/ext4/mballoc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 15fc7105becc..74da24c9bf14 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -1555,8 +1555,7 @@ ext4_mb_load_buddy_gfp(struct super_block *sb, ext4_group_t group, > put_page(page); > if (e4b->bd_bitmap_page) > put_page(e4b->bd_bitmap_page); > - if (e4b->bd_buddy_page) > - put_page(e4b->bd_buddy_page); > + > e4b->bd_buddy = NULL; > e4b->bd_bitmap = NULL; > return ret; > -- > 2.30.0 > Feel free to add: Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
