On Fri, Feb 10, 2023 at 03:48:08AM +0800, Kemeng Shi wrote:
> We always get ext4_group_desc with group + 1 and ext4_group_info with
> group to check if we need do initialize ext4_group_info for the group.
> Just get ext4_group_desc with group for ext4_group_info initialization
> check.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
> ---
> fs/ext4/mballoc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 352ac9139fee..f24f80ecf318 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2570,13 +2570,13 @@ void ext4_mb_prefetch_fini(struct super_block *sb, ext4_group_t group,
> unsigned int nr)
> {
> while (nr-- > 0) {
> - struct ext4_group_desc *gdp = ext4_get_group_desc(sb, group,
> - NULL);
> - struct ext4_group_info *grp = ext4_get_group_info(sb, group);
> + struct ext4_group_desc *gdp;
> + struct ext4_group_info *grp;
>
> if (!group)
> group = ext4_get_groups_count(sb);
> group--;
> + gdp = ext4_get_group_desc(sb, group, NULL);
> grp = ext4_get_group_info(sb, group);
>
> if (EXT4_MB_GRP_NEED_INIT(grp) &&
> --
> 2.30.0
>
This is a duplicate of [1] :)
But I'm okay with this going in as that patchseries might take some time
to get merged. Feel free to add:
Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
[1] https://lore.kernel.org/r/85bbcb3774e38de65b737ef0000241ddbdda73aa.1674822311.git.ojaswin@xxxxxxxxxxxxx
