Hi zhanchengbin, Thank you for the patch! Yet something to improve: [auto build test ERROR on tytso-ext4/dev] [also build test ERROR on jack-fs/for_next linus/master v6.2-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/zhanchengbin/ext4-fix-inode-tree-inconsistency-caused-by-ENOMEM-in-ext4_split_extent_at/20230213-114334 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev patch link: https://lore.kernel.org/r/20230213040522.3339406-3-zhanchengbin1%40huawei.com patch subject: [PATCH v4 2/2] ext4: clear the verified flag of the modified leaf or idx if error config: arm-randconfig-r024-20230213 (https://download.01.org/0day-ci/archive/20230213/202302131414.5RKeHgAZ-lkp@xxxxxxxxx/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db0e6591612b53910a1b366863348bdb9d7d2fb1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/c6de5d67952addd5ffa288574ed55ebe7aeba755 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review zhanchengbin/ext4-fix-inode-tree-inconsistency-caused-by-ENOMEM-in-ext4_split_extent_at/20230213-114334 git checkout c6de5d67952addd5ffa288574ed55ebe7aeba755 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302131414.5RKeHgAZ-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> fs/ext4/extents.c:1760:32: error: member reference type 'struct ext4_ext_path' is not a pointer; did you mean to use '.'? clear_buffer_verified(path[k]->p_bh); ~~~~~~~^~ . fs/ext4/extents.c:2352:36: error: member reference type 'struct ext4_ext_path' is not a pointer; did you mean to use '.'? clear_buffer_verified(path[depth]->p_bh); ~~~~~~~~~~~^~ . 2 errors generated. vim +1760 fs/ext4/extents.c 1699 1700 /* 1701 * ext4_ext_correct_indexes: 1702 * if leaf gets modified and modified extent is first in the leaf, 1703 * then we have to correct all indexes above. 1704 * TODO: do we need to correct tree in all cases? 1705 */ 1706 static int ext4_ext_correct_indexes(handle_t *handle, struct inode *inode, 1707 struct ext4_ext_path *path) 1708 { 1709 struct ext4_extent_header *eh; 1710 int depth = ext_depth(inode); 1711 struct ext4_extent *ex; 1712 __le32 border; 1713 int k, err = 0; 1714 1715 eh = path[depth].p_hdr; 1716 ex = path[depth].p_ext; 1717 1718 if (unlikely(ex == NULL || eh == NULL)) { 1719 EXT4_ERROR_INODE(inode, 1720 "ex %p == NULL or eh %p == NULL", ex, eh); 1721 return -EFSCORRUPTED; 1722 } 1723 1724 if (depth == 0) { 1725 /* there is no tree at all */ 1726 return 0; 1727 } 1728 1729 if (ex != EXT_FIRST_EXTENT(eh)) { 1730 /* we correct tree if first leaf got modified only */ 1731 return 0; 1732 } 1733 1734 /* 1735 * TODO: we need correction if border is smaller than current one 1736 */ 1737 k = depth - 1; 1738 border = path[depth].p_ext->ee_block; 1739 err = ext4_ext_get_access(handle, inode, path + k); 1740 if (err) 1741 return err; 1742 path[k].p_idx->ei_block = border; 1743 err = ext4_ext_dirty(handle, inode, path + k); 1744 if (err) 1745 return err; 1746 1747 while (k--) { 1748 /* change all left-side indexes */ 1749 if (path[k+1].p_idx != EXT_FIRST_INDEX(path[k+1].p_hdr)) 1750 break; 1751 err = ext4_ext_get_access(handle, inode, path + k); 1752 if (err) 1753 break; 1754 path[k].p_idx->ei_block = border; 1755 err = ext4_ext_dirty(handle, inode, path + k); 1756 if (err) 1757 break; 1758 } 1759 while (!(k < 0) && k++ < depth) > 1760 clear_buffer_verified(path[k]->p_bh); 1761 1762 return err; 1763 } 1764 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
