On Sat, Jan 28, 2023 at 02:46:51PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Some .c files in lib/uuid/ contain the following: > > #ifdef _WIN32 > #define _WIN32_WINNT 0x0500 > #include <windows.h> > #define UUID MYUUID > #endif > > This seems to have been intended to allow the use of a local "UUID" type > without colliding with "UUID" in the Windows API. However, this is > unnecessary because there's no local "UUID" type -- there's only uuid_t. > > None of these .c files need the include of windows.h, either. > > Finally, the unconditional definition of _WIN32_WINNT causes a compiler > warning when the user defines _WIN32_WINNT themself. > > Since this code is unnecessary and is causing problems, just remove it. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> Thanks, applied to the maint branch. - Ted
