On Tue, 29 Nov 2022 15:02:39 +0800, lihaoxiang (F) wrote:
> In our knowledge, ext2fs_mmp_stop use to process the rest of work
> when mmp will finish. Critically, it must check if the mmp block is
> not changed. But there exist an error in comparing the mmp and mmp_cmp.
>
> Look to ext2fs_mmp_read, the assignment of mmp_cmp retrieve from the
> superblock of disk and it copy to mmp_buf if mmp_buf is not none
> and not equal to mmp_cmp in the meanwhile. However, ext2fs_mmp_stop
> pass the no NULL pointer fs->mmp_buf which has possed the mmp info to
> ext2fs_mmp_read. Consequently, ext2fs_mmp_read override fs->mmp_buf
> by fs->mmp_cmp so that loss the meaning of comparing themselves
> after that and worse yet, couldn't judge whether the struct of mmp
> has changed.
>
> [...]
Applied, thanks!
[1/1] mmp:fix wrong comparison in ext2fs_mmp_stop
(no commit info)
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>
