Am Di., 10. Jan. 2023 um 09:52 Uhr schrieb Christoph Hellwig <hch@xxxxxxxxxxxxx>: > On Mon, Jan 09, 2023 at 01:46:42PM +0100, Andreas Gruenbacher wrote: > > We can handle that by adding a new IOMAP_NOCREATE iterator flag and > > checking for that in iomap_get_folio(). Your patch then turns into > > the below. > > Exactly. And as I already pointed out in reply to Dave's original > patch what we really should be doing is returning an ERR_PTR from > __filemap_get_folio instead of reverse-engineering the expected > error code. > > The only big question is if we should apply Dave's patch first as a bug > fix before this series, and I suspect we should do that. Sounds fine. I assume Dave is going to send an update. Thanks, Andreas