On Sun, Jan 08, 2023 at 08:40:30PM +0100, Andreas Gruenbacher wrote: > +static struct folio *__iomap_get_folio(struct iomap_iter *iter, loff_t pos, > + size_t len) > +{ > + const struct iomap_page_ops *page_ops = iter->iomap.page_ops; > + > + if (page_ops && page_ops->page_prepare) > + return page_ops->page_prepare(iter, pos, len); > + else > + return iomap_get_folio(iter, pos); Nit: No need for an else after the return. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>