> + if (page_ops && page_ops->page_prepare) > + folio = page_ops->page_prepare(iter, pos, len); > + else > + folio = iomap_get_folio(iter, pos); > + if (IS_ERR(folio)) > return PTR_ERR(folio); I'd love to have a iomap_get_folio helper for this sequence so that we match iomap_put_folio. That would require renaming the current iomap_get_folio to __iomap_get_folio. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>