Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Subject: Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 4 Jan 2023 19:08:17 +0000
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx
In-reply-to: <Y7W9Dfub1WeTvG8G@magnolia>
References: <20221231150919.659533-1-agruenba@redhat.com> <20221231150919.659533-8-agruenba@redhat.com> <Y7W9Dfub1WeTvG8G@magnolia>

On Wed, Jan 04, 2023 at 09:53:17AM -0800, Darrick J. Wong wrote:
> I wonder if this should be reworked a bit to reduce indenting:
> 
> 	if (PTR_ERR(folio) == -ESTALE) {

FYI this is a bad habit to be in.  The compiler can optimise

	if (folio == ERR_PTR(-ESTALE))

better than it can optimise the other way around.

Follow-Ups:
- Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
  - From: Christoph Hellwig

References:
- [PATCH v5 0/9] Turn iomap_page_ops into iomap_folio_ops
  - From: Andreas Gruenbacher
- [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
  - From: Andreas Gruenbacher
- Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
Next by Date: Re: [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build
Previous by thread: Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
Next by thread: Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]