On Wed, Jan 04, 2023 at 01:04:01AM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Minus does not mean equals. > > Besides fixing an obvious bug, this avoids the following compiler > warning with clang -Wall: > > tune2fs.c:3625:20: warning: expression result unused [-Wunused-value] > fsuuid->fsu_len - UUID_SIZE; > ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~ Looks good, thanks! Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > Fixes: a83e199da0ca ("tune2fs: Add support for get/set UUID ioctls.") > Cc: Jeremy Bongio <bongiojp@xxxxxxxxx> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > misc/tune2fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/misc/tune2fs.c b/misc/tune2fs.c > index 088f87e5..7937b8b5 100644 > --- a/misc/tune2fs.c > +++ b/misc/tune2fs.c > @@ -3622,7 +3622,7 @@ _("Warning: The journal is dirty. You may wish to replay the journal like:\n\n" > ret = -1; > #ifdef __linux__ > if (fsuuid) { > - fsuuid->fsu_len - UUID_SIZE; > + fsuuid->fsu_len = UUID_SIZE; > fsuuid->fsu_flags = 0; > memcpy(&fsuuid->fsu_uuid, new_uuid, UUID_SIZE); > ret = ioctl(fd, EXT4_IOC_SETFSUUID, fsuuid); > -- > 2.39.0 >