On Fri 30-12-22 15:18:58, Tanmay Bhushan wrote:
> ext4_update_backup_sb checks for err having some value
> after unlocking buffer. But err has not been updated
> till that point in any code which will lead execution
> of the code in question.
>
> Signed-off-by: Tanmay Bhushan <007047221b@xxxxxxxxx>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/ext4/ioctl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 8067ccda34e4..2e8c34036313 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,
> set_buffer_uptodate(bh);
> unlock_buffer(bh);
>
> - if (err)
> - goto out_bh;
> -
> if (handle) {
> err = ext4_handle_dirty_metadata(handle, NULL, bh);
> if (err)
> --
> 2.34.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
