On Mon, 31 Oct 2022 13:58:33 +0800, Gaosheng Cui wrote:
> Shifting signed 32-bit value by 31 bits is undefined, so changing
> significant bit to unsigned. The UBSAN warning calltrace like below:
>
> UBSAN: shift-out-of-bounds in fs/ext4/ext4.h:591:2
> left shift of 1 by 31 places cannot be represented in type 'int'
> Call Trace:
> <TASK>
> dump_stack_lvl+0x7d/0xa5
> dump_stack+0x15/0x1b
> ubsan_epilogue+0xe/0x4e
> __ubsan_handle_shift_out_of_bounds+0x1e7/0x20c
> ext4_init_fs+0x5a/0x277
> do_one_initcall+0x76/0x430
> kernel_init_freeable+0x3b3/0x422
> kernel_init+0x24/0x1e0
> ret_from_fork+0x1f/0x30
> </TASK>
>
> [...]
Applied, thanks!
[1/1] ext4: fix undefined behavior in bit shift for ext4_check_flag_values
commit: 0cd464d06ba0b9941dd285042909dc4d94adb373
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>
