On Fri, Dec 02, 2022 at 07:39:25PM +0100, Jan Kara wrote: > I have also modified ext4_writepages() to use write_cache_pages() instead of > generic_writepages() so now we don't expose .writepage hook at all. We still > keep ext4_writepage() as a callback for write_cache_pages(). Nice! > We should refactor > that path as well and get rid of ext4_writepage() completely but that is for a > separate cleanup. Agreed. > Also note that jbd2 still uses generic_writepages() in its > jbd2_journal_submit_inode_data_buffers() helper because it is still used from > OCFS2. Again, something to be dealt with in a separate patchset. Indeed. I think simply moving jbd2_journal_submit_inode_data_buffers to ocfs2 and then open coding generic_writepages will be the right thing to do here.
