On Tue, Nov 15, 2022 at 05:18:11PM -0800, Eric Biggers wrote: > On Sun, Nov 06, 2022 at 02:48:34PM -0800, Eric Biggers wrote: > > > > This series fixes several bugs in the fast-commit feature. > > > > Patch 6 may be the most controversial patch of this series, since it > > would make old kernels unable to replay fast-commit journals created by > > new kernels. I'd appreciate any thoughts on whether that's okay. I can > > drop that patch if needed. > > > > I've tested that this series doesn't introduce any regressions with > > 'gce-xfstests -c ext4/fast_commit -g auto'. Note that ext4/039, > > ext4/053, and generic/475 fail both before and after. > > > > Eric Biggers (7): > > ext4: disable fast-commit of encrypted dir operations > > ext4: don't set up encryption key during jbd2 transaction > > ext4: fix leaking uninitialized memory in fast-commit journal > > ext4: add missing validation of fast-commit record lengths > > ext4: fix unaligned memory access in ext4_fc_reserve_space() > > ext4: fix off-by-one errors in fast-commit block filling > > ext4: simplify fast-commit CRC calculation > > > > fs/ext4/ext4.h | 4 +- > > fs/ext4/fast_commit.c | 203 ++++++++++++++++++------------------ > > fs/ext4/fast_commit.h | 3 +- > > fs/ext4/namei.c | 44 ++++---- > > include/trace/events/ext4.h | 7 +- > > 5 files changed, 132 insertions(+), 129 deletions(-) > > > > > > base-commit: 089d1c31224e6b266ece3ee555a3ea2c9acbe5c2 > > Any thoughts on this patch series? > > - Eric Ping? - Eric
