On Nov 7, 2022, at 06:22, Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> wrote:
>
> f_crashdisk test failed with UNIX_IO_FORCE_BOUNCE=yes due to unbalanced
> mutex unlock in below path.
>
> This patch fixes it.
>
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
> ---
> lib/ext2fs/unix_io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/ext2fs/unix_io.c b/lib/ext2fs/unix_io.c
> index e53db333..5b894826 100644
> --- a/lib/ext2fs/unix_io.c
> +++ b/lib/ext2fs/unix_io.c
> @@ -305,7 +305,6 @@ bounce_read:
> while (size > 0) {
> actual = read(data->dev, data->bounce, align_size);
> if (actual != align_size) {
> - mutex_unlock(data, BOUNCE_MTX);
This patch doesn't show enough context, but AFAIK this is jumping before mutex_down()
is called, so this *should* be correct as is?
Cheers, Andreas
> actual = really_read;
> buf -= really_read;
> size += really_read;
> --
> 2.37.3
>
