Re: [PATCH 7/9] jfs: remove ->writepage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/13/22 10:29AM, Christoph Hellwig wrote:
->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or a a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove
the ->writepage implementation.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Acked-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>

---
  fs/jfs/inode.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
index d1ec920aa030a..8ac10e3960508 100644
--- a/fs/jfs/inode.c
+++ b/fs/jfs/inode.c
@@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock,
  	return rc;
  }
-static int jfs_writepage(struct page *page, struct writeback_control *wbc)
-{
-	return block_write_full_page(page, jfs_get_block, wbc);
-}
-
  static int jfs_writepages(struct address_space *mapping,
  			struct writeback_control *wbc)
  {
@@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = {
  	.invalidate_folio = block_invalidate_folio,
  	.read_folio	= jfs_read_folio,
  	.readahead	= jfs_readahead,
-	.writepage	= jfs_writepage,
  	.writepages	= jfs_writepages,
  	.write_begin	= jfs_write_begin,
  	.write_end	= jfs_write_end,
  	.bmap		= jfs_bmap,
  	.direct_IO	= jfs_direct_IO,
+	.migrate_folio	= buffer_migrate_folio,
  };
/*



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux