On Tue, 25 Oct 2022 12:02:06 +0800, Jason Yan wrote: > The return value is wrong in ext4_load_and_init_journal(). The local > variable 'err' need to be initialized before goto out. The original code > in __ext4_fill_super() is fine because it has two return values 'ret' > and 'err' and 'ret' is initialized as -EINVAL. After we factor out > ext4_load_and_init_journal(), this code is broken. So fix it by directly > returning -EINVAL in the error handler path. > > [...] Applied, thanks! [1/1] ext4: fix wrong return err in ext4_load_and_init_journal() commit: 9f2a1d9fb33a2129a9ba29bc61d3f14adb28ddc2 Best regards, -- Theodore Ts'o <tytso@xxxxxxx>