On Fri, Oct 21, 2022 at 05:19:50PM -0400, Eric Whitney wrote: > generic/455 fails when run on an ext4 bigalloc file system. Its > fsx invocations can make insert range and collapse range calls whose > arguments are not cluster aligned, and ext4 will fail those calls for > bigalloc. They can be suppressed by adding the FSX_AVOID environment > variable to the fsx invocation and setting its value appropriately in > the test environment, as is done for other fsx-based tests. This > avoids the need to exclude the test to avoid failures and makes it > possible to take advantage of the remainder of its coverage. > > Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> > --- > tests/generic/455 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/455 b/tests/generic/455 > index 649b5410..c13d872c 100755 > --- a/tests/generic/455 > +++ b/tests/generic/455 > @@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV" > seeds=(0 0 0 0) > # Run fsx for a while > for j in `seq 0 $((NUM_FILES-1))`; do > - run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j & > + run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j & generic/457 needs this fix as well. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx