ping...
On 2022/10/10 16:56, zhanchengbin wrote:
I find a error in misc/fsck.c, if run the fsck -N command, processes
don't execute, just show what would be done. However, the pid whose
value is -1 is added to the instance_list list in the execute
function,if the kill_all function is called later, kill(-1, signum)
is executed, Signals are sent to all processes except the number one
process and itself. Other processes will be killed if they use the
default signal processing function.
Signed-off-by: zhanchengbin <zhanchengbin1@xxxxxxxxxx>
Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
---
V1->V2:
Anything <= 0 is a bug and can have unexpected consequences if
we actually call the kill(). So change inst->pid==-1 to inst->pid<=0.
misc/fsck.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/misc/fsck.c b/misc/fsck.c
index 4efe10ec..c56d1b00 100644
--- a/misc/fsck.c
+++ b/misc/fsck.c
@@ -546,6 +546,8 @@ static int kill_all(int signum)
for (inst = instance_list; inst; inst = inst->next) {
if (inst->flags & FLAG_DONE)
continue;
+ if (inst->pid <= 0)
+ continue;
kill(inst->pid, signum);
n++;
}
