On Thu, 25 Aug 2022 12:06:57 +0200, Lukas Czerner wrote:
> Currently the I_DIRTY_TIME will never get set if the inode already has
> I_DIRTY_INODE with assumption that it supersedes I_DIRTY_TIME. That's
> true, however ext4 will only update the on-disk inode in
> ->dirty_inode(), not on actual writeback. As a result if the inode
> already has I_DIRTY_INODE state by the time we get to
> __mark_inode_dirty() only with I_DIRTY_TIME, the time was already filled
> into on-disk inode and will not get updated until the next I_DIRTY_INODE
> update, which might never come if we crash or get a power failure.
>
> [...]
Applied, thanks!
[1/1] fs: record I_DIRTY_TIME even if inode already has I_DIRTY_INODE
commit: 625e1e67b66245b93ccae868cd4a950d257de003
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>
