On 22/09/13 09:14PM, Zhiqiang Liu wrote: > > In ext2fs_open2(), fs->image_header is assigned by calling io_channel_read_blk, > successfully. If fs->image_header->magic_number is not equal to EXT2_ET_MAGIC_E2IMAGE, > we should go to cleanup tag to free resouce and return errcode (EXT2_ET_MAGIC_E2IMAGE). > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@xxxxxxxxxx> > --- > lib/ext2fs/openfs.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks good to me. Feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> -ritesh