On Wed 31-08-22 17:31:48, Zorro Lang wrote: > On Mon, Aug 29, 2022 at 12:06:57PM +0200, Jan Kara wrote: > > On Sun 28-08-22 10:48:58, Zorro Lang wrote: > > > On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote: > > > > Plan to remove noacl and nouser_xattr mount option in kernel because they > > > > are deprecated[1]. So remove nouser_xattr test in here. > > > > > > What's the [1]? > > > > > > We'd better to be careful when we want to remove a testing coverage. I'm not > > > sure if they've decided to removed this mount option, the ext4/053 is an > > > important test case for ext4, so I'd like to hear their opinion. > > > > Yes, the option is long deprecated and we want to remove it from ext4. But > > I think you might want to see official ack from Ted as a maintainer on this > > :). Ted? > > It's fine for me, if anyone stand for ext4 list to give this patch a RVB, due > to it's not a bug fix or new testing, it's a testing deduction, and only affect > ext4 testing. Sure, feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > > > > Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> > > > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> > > > > --- > > > > tests/ext4/053 | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/tests/ext4/053 b/tests/ext4/053 > > > > index 555e474e..5d2c478a 100755 > > > > --- a/tests/ext4/053 > > > > +++ b/tests/ext4/053 > > > > @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do > > > > mnt oldalloc removed > > > > mnt orlov removed > > > > mnt -t user_xattr > > > > - mnt nouser_xattr > > > > > > > > if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then > > > > mnt -t acl > > > > -- > > > > 2.27.0 > > > > > > > > > -- > > Jan Kara <jack@xxxxxxxx> > > SUSE Labs, CR > > > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
