On Wed, Aug 10, 2022 at 11:18:23PM -0400, Theodore Ts'o wrote: > Hi Lukas, > > Could you move get_devname() into its own file in lib/support? e.g., > create a devname.c and devname.h. > > The reason for this is that plausible.c tries to call libmagic via > dlopen() so we don't need to drag libmagic into the minimal package > set for distros. But that means that any executiables that try to use > devname() will drag in lib/support/pausible.c, which means if you > don't change the makefiles to link in -ldl, static linking will fail: > > - Ted Ah, I didn't notice that. I'll move it into a separate file, devname.[ch] sounds good. Thanks! -Lukas
