Thanks for pointing to the libsupport. I looking into kernel-jbd.h as example (it also don’t export outside of e2fsprogs), but libsupport is lost from my radar. Lack of tag v3 is big lost also. It mean debugfs don’t able to print log records correctly if block number over 2^32. Alex > On 3 Aug 2022, at 22:58, Theodore Ts'o <tytso@xxxxxxx> wrote: > > On Wed, Aug 03, 2022 at 10:54:07AM +0300, Alexey Lyashkov wrote: >> debugfs and e2fsck have a so much code duplication in journal handing. >> debugfs have lack a many journal features handing also. >> Let's start code merging to avoid code duplication and lack features. > > This is definitely worth doing, and as you've pointed out, there are a > number of features which are in e2fsck/journal.c, which are not in > debugfs/journal.c. The most notable one which I picked up on is the > fast_commit code --- which is in the master/next branch, but not in > the maint branch. > > I suggest that we move the functionality into the libsupport library > first. I want to make sure we get the abstractions right before we > "cast them into stone" by moving the functions to libext2fs. > Libsupport is not exported outside of e2fsprogs, so if we decide we > want to change function signatures, or make some functions private, we > can do that more easily if we experiment with moving things into > libsupport first. > > - Ted
