On 22/06/21 02:39AM, Matthew Wilcox wrote:
> On Mon, Jun 20, 2022 at 11:28:40AM +0530, Ritesh Harjani wrote:
> > @@ -1636,14 +1636,12 @@ static int jbd2_write_superblock(journal_t *journal, int write_flags)
> > sb->s_checksum = jbd2_superblock_csum(journal, sb);
> > get_bh(bh);
> > bh->b_end_io = end_buffer_write_sync;
> > - ret = submit_bh(REQ_OP_WRITE, write_flags, bh);
> > + submit_bh(REQ_OP_WRITE, write_flags, bh);
> > wait_on_buffer(bh);
> > if (buffer_write_io_error(bh)) {
> > clear_buffer_write_io_error(bh);
> > set_buffer_uptodate(bh);
> > ret = -EIO;
> > - }
> > - if (ret) {
> > printk(KERN_ERR "JBD2: Error %d detected when updating "
> > "journal superblock for %s.\n", ret,
> > journal->j_devname);
>
> Maybe rephrase the error message? And join it together to match the
> current preferred style.
>
> printk(KERN_ERR "JBD2: I/O error when updating journal superblock for %s.\n",
> journal->j_devname);
Sure, I will update the printk message like above and send out a v3
(since I haven't receieved any other comments so I think v3 should be good to be
picked up now)
-ritesh
