Hi "Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tytso-ext4/dev] [also build test WARNING on jack-fs/for_next linus/master v5.19-rc1 next-20220603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/Cache-quota-files-in-the-page-cache/20220606-021629 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220606/202206061211.HKxbKbgS-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-18-g56afb504-dirty # https://github.com/intel-lab-lkp/linux/commit/a7ff347e002ef476c8c116f30858f83529638a9b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Cache-quota-files-in-the-page-cache/20220606-021629 git checkout a7ff347e002ef476c8c116f30858f83529638a9b # save the config file mkdir build_dir && cp config build_dir/.config make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash fs/quota/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> sparse warnings: (new ones prefixed by >>) >> fs/quota/dquot.c:2184:33: sparse: sparse: incompatible types in comparison expression (different type sizes): >> fs/quota/dquot.c:2184:33: sparse: unsigned int * >> fs/quota/dquot.c:2184:33: sparse: unsigned long * vim +2184 fs/quota/dquot.c 2165 2166 ssize_t generic_quota_read(struct super_block *sb, int type, char *data, 2167 size_t len, loff_t pos) 2168 { 2169 struct inode *inode = sb_dqopt(sb)->files[type]; 2170 struct address_space *mapping = inode->i_mapping; 2171 size_t toread; 2172 pgoff_t index; 2173 loff_t i_size = i_size_read(inode); 2174 2175 if (pos > i_size) 2176 return 0; 2177 if (pos + len > i_size) 2178 len = i_size - pos; 2179 toread = len; 2180 index = pos / PAGE_SIZE; 2181 2182 while (toread > 0) { 2183 struct folio *folio = read_mapping_folio(mapping, index, NULL); > 2184 size_t tocopy = min(toread, PAGE_SIZE - offset_in_page(pos)); 2185 void *src; 2186 2187 if (folio == ERR_PTR(-ENOMEM)) { 2188 memalloc_retry_wait(GFP_NOFS); 2189 continue; 2190 } else if (IS_ERR(folio)) 2191 return PTR_ERR(folio); 2192 2193 src = kmap_local_folio(folio, offset_in_folio(folio, pos)); 2194 memcpy(data, src, tocopy); 2195 kunmap_local(src); 2196 folio_put(folio); 2197 2198 toread -= tocopy; 2199 data += tocopy; 2200 pos += tocopy; 2201 index++; 2202 } 2203 return len; 2204 } 2205 EXPORT_SYMBOL(generic_quota_read); 2206 -- 0-DAY CI Kernel Test Service https://01.org/lkp
