On 22/05/28 07:00PM, Baokun Li wrote: > In ext4_mb_normalize_request, the size of the allocation request is > limited to no more than EXT4_BLOCKS_PER_GROUP. Ritesh mentions that this > does not take into account the case of flex_bg groups. So we should add > support for flex_bg to make the physical blocks of large files contiguous. My only concern here was that what if we are at the flex group end boundary and decide to take the size as of flex group size. How are we detecting that case. But, I haven't yet looked at this patch of yours (as I am on travel for next few days), but if this requires further discussion, we can work on this seperately and let the other two patches go in as those are part of the bug fixes which you identified (just my thoughts). -ritesh