On Wed, May 25, 2022 at 08:18:22AM -0700, Joe Perches wrote: > On Wed, 2022-05-25 at 05:48 -0700, Yu Zhe wrote: > > printk() should include KERN_<LEVEL> facility level, add them. > > NACK. > > checkpatch is just a guide. checkpatch-only patches are something which I will tend to just ignore. (Even if the changes are correct, which they are not in this case). In addition to all of the other reasons why such drive-by checkpatch patches are frowned upon, I would appreciate it if the code paths that are changed are actually *tested*, at which point you might have noticed that your changes werenn't doing the right thing. (BTW I'll also note that the code involved that is almost never enabled --- the developer would need to manually insert a "#define DX_DEBUG" at the beginning of the fs/ext4/namei.c source file for the code to be enabled. It's only intended to be used by developers who are doing surgery to the htree code.) - Ted
