Hi Eric, Ted, Sorry for the second submission of this series on the same day. Just a batch of simple fixes, so I hope it is getting close to merging. This is v6 of this series (thank you for the feedback!) . This picks up a few r-b tags and apply the comments from Eric. No big changes, all documented in the respective patches. Once again, tested with fstests generic/556. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/ext4.h | 49 +++++++++--------- fs/ext4/namei.c | 120 ++++++++++++++------------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 103 ++++++++++++-------------------------- fs/f2fs/f2fs.h | 15 +++++- fs/f2fs/namei.c | 11 ++--- fs/f2fs/recovery.c | 5 +- fs/f2fs/super.c | 8 +-- fs/libfs.c | 68 +++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 10 files changed, 187 insertions(+), 200 deletions(-) -- 2.36.1
