On 22/05/14 08:42PM, Eric Biggers wrote: > On Sat, May 14, 2022 at 10:52:48PM +0530, Ritesh Harjani wrote: > > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > > The include <linux/uuid.h> can be removed from this file. Yes. I will remove this from ioctl.c and will add it to crypto.c for generate_random_uuid() definition. > > > diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c > [...] > > +int ext4_ioc_get_encryption_pwsalt(struct file *filp, void __user *arg) > > ext4 has more functions named "ext4_ioctl_*" thtan "ext4_ioc_*", so it might be > worth adding those extra 2 letters for consistency. You are right. > > Other than the above minor nits this looks good, thanks! > > Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> Thanks for a thorough review. I will make these changes and send out a v3 soon. -ritesh
