On 22/05/14 08:33PM, Eric Biggers wrote: > On Sat, May 14, 2022 at 10:52:46PM +0530, Ritesh Harjani wrote: > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > > index a743b1e3b89e..9100f0ba4a52 100644 > > --- a/fs/ext4/ext4.h > > +++ b/fs/ext4/ext4.h > > @@ -2731,6 +2731,9 @@ extern int ext4_fname_setup_ci_filename(struct inode *dir, > > struct ext4_filename *fname); > > #endif > > > > +/* ext4 encryption related stuff goes here crypto.c */ > > +extern const struct fscrypt_operations ext4_cryptops; > > + > > #ifdef CONFIG_FS_ENCRYPTION > > Shouldn't the declaration of ext4_cryptops go in the CONFIG_FS_ENCRYPTION block? Sure yes. I should move that within CONFIG_FS_ENCRYPTION block. > > Otherwise this patch looks good, thanks. > > Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> Thanks for the review. -ritesh
