On Wed, May 11, 2022 at 06:20:23PM +0530, Ritesh Harjani wrote: > > +static int ext4_check_test_dummy_encryption(const struct fs_context *fc, > > + struct super_block *sb) > > Maybe the function name should match with other option checking, like > ext4_check_test_dummy_encryption_consistency() similar to > ext4_check_quota_consistency(). This makes it clear that both are residents of > ext4_check_opt_consistency() > > One can argue it makes the function name quite long. So I don't have hard > objections anyways. > > So either ways, feel free to add - > > Reviewed-by: Ritesh Harjani <ritesh.list@xxxxxxxxx> I did consider that, but that name seemed too long, as you mentioned. Thanks for the review! - Eric
