RE: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> Sent: Monday, April 18, 2022 3:22 PM
> To: 常凤楠 <changfengnan@xxxxxxxx>
> Cc: jaegeuk@xxxxxxxxxx; chao@xxxxxxxxxx; tytso@xxxxxxx;
> adilger.kernel@xxxxxxxxx; axboe@xxxxxxxxx; linux-block@xxxxxxxxxxxxxxx;
> linux-ext4@xxxxxxxxxxxxxxx; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt
> 
> On Mon, Apr 18, 2022 at 02:33:11PM +0800, Fengnan Chang via
> Linux-f2fs-devel wrote:
> > Notify when mount filesystem with -o inlinecrypt option, but the
> > device not support inlinecrypt.
> >
> > Signed-off-by: Fengnan Chang <changfengnan@xxxxxxxx>
> 
> You didn't include a cover letter in this patchset.  Can you explain what
> problem this patchset is meant to solve?

What I'm try to make is when devices not support inlinecrypt, do not show inlinecrypt in mount option. 
When I test fscrypt first, it make me confused. Not a real problem, just make this logical more reasonable.
Do you think this needs to be revised?

> 
> Note that there are multiple factors that affect whether inline encryption can
> be used with a particular file, such as whether the device supports the
> required encryption mode, data unit size, and data unit number size.  So
> your warning might not trigger even if inline encryption can't be used.  Also,
> your warning will never trigger if the kernel has
> CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK=y.

I get it.

> 
> I recently sent out a patch that makes fs/crypto/ consistently log a message
> when starting to use an encryption implementation for the first time:
> https://lore.kernel.org/r/20220414053415.158986-1-ebiggers@xxxxxxxxxx.
> It already did this for the crypto API, but not blk-crypto.  Being silent for
> blk-crypto was somewhat of an oversight.  These log messages make it clear
> which encryption implementations are in use.
> 
> Does that patch solve the problem you are trying to solve?

I think it's a different point.

Thanks.

> 
> - Eric




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux