Re: [PATCH v2 1/5] ext4: convert i_fc_lock to spinlock

[Daejun Park <daejun7.park@xxxxxxxxxxx>]

Hi Harshad Shirwadkar,

...
>@@ -427,11 +427,11 @@ static int __track_dentry_update(struct inode *inode, void *arg, bool update)
> 	struct dentry *dentry = dentry_update->dentry;
> 	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
> 
>-	mutex_unlock(&ei->i_fc_lock);
>+	spin_unlock(&ei->i_fc_lock);
> 	node = kmem_cache_alloc(ext4_fc_dentry_cachep, GFP_NOFS);
Is it sleep-safe with spinlock?

> 	if (!node) {
> 		ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, NULL);
>-		mutex_lock(&ei->i_fc_lock);
>+		spin_lock(&ei->i_fc_lock);
> 		return -ENOMEM;
> 	}
> 

Thanks,
Daejun