On Fri, Mar 4, 2022 at 10:01 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Use the %pg format specifier to save on stack consuption and code size.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Acked-by: Song Liu <song@xxxxxxxxxx>
> ---
> drivers/md/raid1.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index c180c188da574..97574575ad0b4 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2069,15 +2069,14 @@ static int fix_sync_read_error(struct r1bio *r1_bio)
> } while (!success && d != r1_bio->read_disk);
>
> if (!success) {
> - char b[BDEVNAME_SIZE];
> int abort = 0;
> /* Cannot read from anywhere, this block is lost.
> * Record a bad block on each device. If that doesn't
> * work just disable and interrupt the recovery.
> * Don't fail devices as that won't really help.
> */
> - pr_crit_ratelimited("md/raid1:%s: %s: unrecoverable I/O read error for block %llu\n",
> - mdname(mddev), bio_devname(bio, b),
> + pr_crit_ratelimited("md/raid1:%s: %pg: unrecoverable I/O read error for block %llu\n",
> + mdname(mddev), bio->bi_bdev,
> (unsigned long long)r1_bio->sector);
> for (d = 0; d < conf->raid_disks * 2; d++) {
> rdev = conf->mirrors[d].rdev;
> --
> 2.30.2
>
