Looks good.
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx>
- Harshad
On Wed, 23 Feb 2022 at 01:45, Jan Kara <jack@xxxxxxx> wrote:
>
> On Wed 23-02-22 02:04:15, Ritesh Harjani wrote:
> > All ext4 & jbd2 trace events starts with "dev Major:Minor".
> > While we are still improving/adding the ftrace events for FC,
> > let's fix last two remaining trace events to follow the same
> > convention.
> >
> > Signed-off-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
>
> OK. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Honza
>
> > ---
> > include/trace/events/ext4.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> > index 6e66cb7ce624..233dbffa5ceb 100644
> > --- a/include/trace/events/ext4.h
> > +++ b/include/trace/events/ext4.h
> > @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan,
> > __entry->off = off;
> > ),
> >
> > - TP_printk("FC scan pass on dev %d,%d: error %d, off %d",
> > + TP_printk("dev %d,%d error %d, off %d",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->error, __entry->off)
> > );
> > @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay,
> > __entry->priv2 = priv2;
> > ),
> >
> > - TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d",
> > + TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->tag, __entry->ino, __entry->priv1, __entry->priv2)
> > );
> > --
> > 2.31.1
> >
> --
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR
