On 22/02/07 01:55PM, Ojaswin Mujoo wrote:
> The current implementation of ext4_resize returned 1 whenever
> there was an error. Modify this to return the correct error code.
> This is important for tests that rely on correct error reporting, by
> the kernel, for ext4 resize functionality.
>
> Additionaly, perform some code cleanup.
Thanks for fixing the error return codes. This looks good to me.
Feel free to add -
Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
Stats on running this stats on my dev machine
<on old kernels>
===================
qemu@qemu:~/src/tools/xfstests-dev$ sudo ./check -s ext4_4k ext4/056
SECTION -- ext4_4k
FSTYP -- ext4
PLATFORM -- Linux/ppc64le qemu 5.4.0-100-generic #113-Ubuntu SMP Thu Feb 3 18:43:11 UTC 2022
MKFS_OPTIONS -- -I 256 -O 64bit -F -b 4096 /dev/loop10
MOUNT_OPTIONS -- -o data=ordered /dev/loop10 /mnt1/scratch
ext4/056 [failed, exit status 1]- output mismatch (see /home/qemu/src/tools/xfstests-dev/results//ext4_4k/ext4/056.out.bad)
--- tests/ext4/056.out 2022-02-19 06:55:22.233659113 +0000
+++ /home/qemu/src/tools/xfstests-dev/results//ext4_4k/ext4/056.out.bad 2022-02-19 06:57:48.931542566 +0000
@@ -1,2 +1,3 @@
QA output created by 056
-Test Succeeded!
+_check_generic_filesystem: filesystem on /dev/loop10 is inconsistent
+(see /home/qemu/src/tools/xfstests-dev/results//ext4_4k/ext4/056.full for details)
...
(Run 'diff -u /home/qemu/src/tools/xfstests-dev/tests/ext4/056.out /home/qemu/src/tools/xfstests-dev/results//ext4_4k/ext4/056.out.bad' to see the entire diff)
Ran: ext4/056
Failures: ext4/056
Failed 1 of 1 tests
SECTION -- ext4_4k
=========================
Ran: ext4/056
Failures: ext4/056
Failed 1 of 1 tests
<on 5.16.0-rc4>
===================
qemu@qemu:~/src/tools/xfstests-dev$ sudo ./check -s ext4_4k -i 10 ext4/056
SECTION -- ext4_4k
FSTYP -- ext4
PLATFORM -- Linux/ppc64le qemu 5.16.0-rc4+ #6 SMP Sat Jan 29 22:07:24 UTC 2022
MKFS_OPTIONS -- -I 256 -O 64bit -F -b 4096 /dev/loop10
MOUNT_OPTIONS -- -o data=ordered /dev/loop10 /mnt1/scratch
ext4/056 9s ... 11s
Ran: ext4/056
Passed all 1 tests
-ritesh
