When test fast commit with xfstests generic/455, some logic issues were found. When a full commit is ongonig, the logic of fast commit tracking seems not correct. The first patch fix the ineligible commit case , and the second patch fix the common fast commit case. After testing this patch set with xfstests log and quick group, no regressions were found, and the generic/455 can pass now. --- v2: drop EXT4_MF_FC_COMMITTING v3: change logic of ext4_fc_mark_ineligible() when set 'handle' as NULL. Fix use-after-free issue for improper use of 'handle' for ext4_fc_mark_ineligible(). Xin Yin (2): ext4: fast commit may not fallback for ineligible commit ext4: fast commit may miss file actions fs/ext4/ext4.h | 8 +++----- fs/ext4/extents.c | 4 ++-- fs/ext4/fast_commit.c | 44 ++++++++++++++++++++++++++++++------------- fs/ext4/inode.c | 4 ++-- fs/ext4/ioctl.c | 4 ++-- fs/ext4/namei.c | 4 ++-- fs/ext4/super.c | 2 +- fs/ext4/xattr.c | 6 +++--- fs/jbd2/commit.c | 2 +- fs/jbd2/journal.c | 2 +- include/linux/jbd2.h | 2 +- 11 files changed, 49 insertions(+), 33 deletions(-) -- 2.25.1
