On Mon 10-01-22 21:28:41, Yang Li wrote: > Add the description of @shrink and @sc in jbd2_journal_shrink_scan() and > jbd2_journal_shrink_count() kernel-doc comment to remove warnings found > by running scripts/kernel-doc, which is caused by using 'make W=1'. > fs/jbd2/journal.c:1296: warning: Function parameter or member 'shrink' > not described in 'jbd2_journal_shrink_scan' > fs/jbd2/journal.c:1296: warning: Function parameter or member 'sc' not > described in 'jbd2_journal_shrink_scan' > fs/jbd2/journal.c:1320: warning: Function parameter or member 'shrink' > not described in 'jbd2_journal_shrink_count' > fs/jbd2/journal.c:1320: warning: Function parameter or member 'sc' not > described in 'jbd2_journal_shrink_count' > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> Thanks! Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/jbd2/journal.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index f13d548e4a7f..ad32fd92d251 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -1287,6 +1287,8 @@ static int jbd2_min_tag_size(void) > > /** > * jbd2_journal_shrink_scan() > + * @shrink: shrinker to work on > + * @sc: reclaim request to process > * > * Scan the checkpointed buffer on the checkpoint list and release the > * journal_head. > @@ -1312,6 +1314,8 @@ static unsigned long jbd2_journal_shrink_scan(struct shrinker *shrink, > > /** > * jbd2_journal_shrink_count() > + * @shrink: shrinker to work on > + * @sc: reclaim request to process > * > * Count the number of checkpoint buffers on the checkpoint list. > */ > -- > 2.20.1.7.g153144c > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
