This patch series looks good to me. Also, it's great to know that generic/455 now passes! :) Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> On Fri, Jan 7, 2022 at 4:12 AM Xin Yin <yinxin.x@xxxxxxxxxxxxx> wrote: > > When test fast commit with xfstests generic/455, some logic issues were > found. When a full commit is ongonig, the logic of fast commit tracking seems > not correct. The first patch fix the ineligible commit case , and the > second patch fix the common fast commit case. > > After testing this patch set with xfstests log and quick group, no > regressions were found, and the generic/455 can pass now. > > Xin Yin (2): > ext4: fast commit may not fallback for ineligible commit > ext4: fast commit may miss file actions > > fs/ext4/ext4.h | 3 ++- > fs/ext4/extents.c | 4 ++-- > fs/ext4/fast_commit.c | 28 +++++++++++++++++++--------- > fs/ext4/inode.c | 4 ++-- > fs/ext4/ioctl.c | 4 ++-- > fs/ext4/namei.c | 4 ++-- > fs/ext4/super.c | 1 + > fs/ext4/xattr.c | 6 +++--- > fs/jbd2/commit.c | 2 +- > fs/jbd2/journal.c | 2 +- > include/linux/jbd2.h | 2 +- > 11 files changed, 36 insertions(+), 24 deletions(-) > > -- > 2.20.1 >