On Fri, 12 Nov 2021 16:22:02 +0100, Jan Kara wrote:
> A user reported FITRIM ioctl failing for him on ext4 on some devices
> without apparent reason. After some debugging we've found out that
> these devices (being LVM volumes) report rather large discard
> granularity of 42MB and the filesystem had 1k blocksize and thus group
> size of 8MB. Because ext4 FITRIM implementation puts discard
> granularity into minlen, ext4_trim_fs() declared the trim request as
> invalid. However just silently doing nothing seems to be a more
> appropriate reaction to such combination of parameters since user did
> not specify anything wrong.
>
> [...]
Applied, thanks!
[1/1] ext4: Avoid trim error on fs with small groups
commit: a4934e25c01ed056dc4af8bef086616e3b083a14
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>
