On Tue, Nov 23, 2021 at 02:31:23PM -0800, Darrick J. Wong wrote: > > - struct super_block *sb = mp->m_super; > > - > > - if (!xfs_buftarg_is_dax(sb, mp->m_ddev_targp) && > > - (!mp->m_rtdev_targp || !xfs_buftarg_is_dax(sb, mp->m_rtdev_targp))) { > > + if (!mp->m_ddev_targp->bt_daxdev && > > + (!mp->m_rtdev_targp || !mp->m_rtdev_targp->bt_daxdev)) { > > Nit: This ^ paren should be indented one more column because it's a > sub-clause of the if() test. Done. > Nit: xfs_alert() already adds a newline to the end of the format string. Already done in the current tree.