The assignment at the end of the function is not necessary The clang_analyzer complains as follows: fs/ext4/mballoc.c:3889:3 warning: Value stored to 'err' is never read Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: luo penghao <luo.penghao@xxxxxxxxxx> --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 089c958..f1258a7 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3886,7 +3886,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block, if (err) goto out_err; sync_dirty_buffer(bitmap_bh); - err = ext4_handle_dirty_metadata(NULL, NULL, gdp_bh); + ext4_handle_dirty_metadata(NULL, NULL, gdp_bh); sync_dirty_buffer(gdp_bh); out_err: -- 2.15.2
