On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > > Just open code the block size and dax_dev == NULL checks in the callers. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > drivers/dax/super.c | 36 ------------------------------------ > > drivers/md/dm-table.c | 22 +++++++++++----------- > > drivers/md/dm.c | 21 --------------------- > > drivers/md/dm.h | 4 ---- > > drivers/nvdimm/pmem.c | 1 - > > drivers/s390/block/dcssblk.c | 1 - > > fs/erofs/super.c | 11 +++++++---- > > fs/ext2/super.c | 6 ++++-- > > fs/ext4/super.c | 9 ++++++--- > > fs/xfs/xfs_super.c | 21 ++++++++------------- > > include/linux/dax.h | 14 -------------- > > 11 files changed, 36 insertions(+), 110 deletions(-) > > [..] if (ext4_has_feature_inline_data(sb)) { > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index d07020a8eb9e3..163ceafbd8fd2 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c [..] > > + if (mp->m_super->s_blocksize != PAGE_SIZE) { > > + xfs_alert(mp, > > + "DAX not supported for blocksize. Turning off DAX.\n"); > > Newlines aren't needed at the end of extX_msg/xfs_alert format strings. Thanks Darrick, I fixed those up.