On Sat 11-09-21 17:00:56, Ye Bin wrote: > As mmp and check_mmp is point to the same data, so there will never > detect conflict. > To solve this issue just compare to local data. > > Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx> Good spotting! Just one nit below. > --- > fs/ext4/mmp.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c > index c781b09a78c9..4433fe7e9e86 100644 > --- a/fs/ext4/mmp.c > +++ b/fs/ext4/mmp.c > @@ -154,6 +154,7 @@ static int kmmpd(void *data) > unsigned long last_update_time; > unsigned long last_check_time; > unsigned long diff; > + char nodename[64]; Perhaps define a constant for the length of nodename and use it here as well as in the declaration of mmp_struct->mmp_nodename? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
