On Thu, Aug 26, 2021 at 09:04:09PM +0800, Zhang Yi wrote: > Now that ext4_do_update_inode() return error before filling the whole > inode data if we fail to set inode blocks in ext4_inode_blocks_set(). > This error should never happen in theory since sb->s_maxbytes should not > have allowed this, we have already init sb->s_maxbytes according to this > feature in ext4_fill_super(). So even through that could only happen due > to the filesystem corruption, we'd better to return after we finish > updating the inode because it may left an uninitialized buffer and we > could read this buffer later in "errors=continue" mode. > > This patch make the updating inode data procedure atomic, call > EXT4_ERROR_INODE() after we dropping i_raw_lock after something bad > happened, make sure that the inode is integrated, and also drop a BUG_ON > and do some small cleanups. > > Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx> > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks, applied. - Ted
