On Mon, Aug 30, 2021 at 01:05:08PM +0300, Denis Efremov wrote: > EXT4_IOC_GETSTATE is only used to read the state flags from the kernel. > > Fixes: 1ad3ea6e0a69 ("ext4: add a new ioctl EXT4_IOC_GETSTATE") > Signed-off-by: Denis Efremov <efremov@xxxxxxxxx> NACK. This will break ABI compatibility, which is way important than getting the ioctl encoding incorrect. If you really care, I suppose we could add an EXT4_IOC_GETSTATE_OLD for the old value, and then support EXT4_IOC_GETSTATE and EXT4_IOC_GETSTATE_OLD for a decade or two until all of the binaries in the world get recompiled. Is it worth it? Eh.... - Ted