[QUESTION] question for commit 2d01ddc86606 ("ext4: save error info to sb through journal if available")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jan,

There is a question about 2d01ddc86606 ("ext4: save error info to sb through journal if available"). This commit describe that we can have checksum failure with follow case:

1. ext4_handle_error will call ext4_commit_super which write directly to the superblock
2. At the same time, jounalled update of the superblock is ongoing

However, after commit 05c2c00f3769 ("ext4: protect superblock modifications with a buffer lock"), all the update for superblock and the csum will be protected with buffer lock. It seems we won't get a csum error after that commit and the journal logic in flush_stashed_error_work seems useless.

Maybe there is something missing... Can you help to explain more for that...


Thanks,
Kun.



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux