On Thu, 22 Jul 2021, Theodore Ts'o wrote: > On Thu, Jul 22, 2021 at 12:35:43PM +0100, Lee Jones wrote: > > On Thu, 20 May 2021, Lee Jones wrote: > > > > > Cc: "Theodore Ts'o" <tytso@xxxxxxx> > > > Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx> > > > Cc: Remy Card <card@xxxxxxxxxxx> > > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxxxxx> > > > Cc: linux-ext4@xxxxxxxxxxxxxxx > > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > > --- > > > fs/ext4/namei.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Any news on this please? > > > > Would you like me to submit a [RESEND]? > > Please don't send "checkpatch.pl --file" patches for the ext4 file > system; if you must, please focus on files in the drivers directory, > where they are more welcome. If developers are making changes to a > file, fixing some checkpatch.pl whines is fine, but white-sapace only > changes just obfuscates "git blame" code archology, and so the costs > far outwieghs the costs. "Fix" is also not the right verb to use. > For more information please see [1]. > > [1] https://gist.github.com/17twenty/8154928 > > If you are looking for subtantive ways of contributing to the ext4 > file system, feel free to look at various syzbot warnings[2] and try > to figure out what is going on there. > > [2] https://syzkaller.appspot.com/upstream > > (In some cases, the syzbot complaint has already been fixed, and it's > just a matter of letting syzbot knoww that it has since been fixed by > a particular commit. See [3] for more details.) > > [3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md This patch doesn't have anything to do with checkpatch. Daniel, who was making more 'substantive' changes to ext4, fixed these whitespace issues in his first submission [0], but were dropped from the second revision for some reason and thus didn't make it into Mainline [1]. This is an attempt to realign his development repo (Android) with Mainline. I had the choice of either backporting the issues back into the Android kernel or upstreaming the original whitespace cleanup. It made more sense to me to draft a patch making one codebase better than another one worse. [0] https://lore.kernel.org/linux-fsdevel/20210203090745.4103054-2-drosen@xxxxxxxxxx/ [1] 471fbbea7ff70 ext4: handle casefolding with encryption -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
